Re: Obsolete comments in ResultRelInfo struct - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Obsolete comments in ResultRelInfo struct
Date
Msg-id CAPmGK140581qQRWA97rb+mW7orTBJ+DMgw5rzS=qgdSCkoX6XA@mail.gmail.com
Whole thread Raw
In response to Re: Obsolete comments in ResultRelInfo struct  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Hi,

On Tue, Aug 12, 2025 at 2:03 AM Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> On Mon, 11 Aug 2025 at 12:25, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >
> >     /*
> >      * Other information needed by child result relations
> >      *
> >      * RootResultRelInfo gives the target relation mentioned in the query.
> >      * Used as the root for tuple routing and/or transition capture.
> >      *
> >      * PartitionTupleSlot is non-NULL if the relation is a partition to route
> >      * tuples into and RootToChild conversion is needed.
> >      */
>
> That seems reasonable.

Cool!

> I think it's also worth adding the "ri_" prefix
> to the field names in those comments.

+1, so I created a patch incorporating your proposal, which I am attaching.

Thanks for the comment!

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Excessive LOG messages from replication slot sync worker
Next
From: Etsuro Fujita
Date:
Subject: Re: Obsolete comments in ResultRelInfo struct