Request a Demo
Home   >   mailing lists

Re: Improve coments on structures in trigger.c - Mailing list pgsql-hackers

From Philip Alger
Subject Re: Improve coments on structures in trigger.c
Date
Msg-id CAPXBC8LWYqQ5bjt3pmjU93f_RWky=8B84X8ADKDbZeHBjfiZWw@mail.gmail.com
Whole thread Raw
In response to Improve coments on structures in trigger.c  (Yugo Nagata <nagata@sraoss.co.jp>)
List pgsql-hackers
Tree view
Hi Yugo,
 
I found that comments in trigger.c describing fields of three different
structures in a comment block.

That makes sense to me.
 
I've attached a patch to improve the comments
by splitting it to three blocks.

I think you could also move the comment beginning on:
   
    * AfterTriggersData has the following fields:

To between:

  typedef struct AfterTriggersTableData AfterTriggersTableData;
> HERE
    typedef struct AfterTriggersData

To keep it consistent with the other comments you moved around.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Refactoring: Use soft error reporting for *_opt_error functions
Next
From: Michael Paquier
Date:
Subject: Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting