Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement - Mailing list pgsql-hackers

From Philip Alger
Subject Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Date
Msg-id CAPXBC8L-31TtFAs0XnDKeOX_u0RX+3J6jEBmge7SkR=TfnWPQA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement  (Philip Alger <paalger0@gmail.com>)
List pgsql-hackers
Tree view


doc said trigger name can not be schema-qualified,
we can not do:
CREATE TRIGGER public.modified_a BEFORE UPDATE OF a ON main_table
FOR EACH ROW WHEN (OLD.a <> NEW.a) EXECUTE PROCEDURE trigger_func('modified_a');
 
+ nameList = textToQualifiedNameList(trgName);


I am wondering if adding an error message if someone inserted a schema name would be advantageous? 

It might be advantageous to show a `trigger name cannot be schema qualified` error to the user. Therefore, I added the check and the tests on v8 attached.

postgres=# SELECT pg_get_trigger_ddl('main_table', 'public.modified_a');
ERROR:  trigger name cannot be schema qualified

Thanks.
 
--
Best, 
Phil Alger
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Add copyright notice to 048_vacuum_horizon_floor.pl
Next
From: Masahiko Sawada
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart