Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement - Mailing list pgsql-hackers

From Philip Alger
Subject Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Date
Msg-id CAPXBC8JV54wejhNAhgSPLgupVkpfpQPwGkjuuY-17GF12S_+-w@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement  (Jim Jones <jim.jones@uni-muenster.de>)
Responses Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
List pgsql-hackers
Tree view
Hi Jim, 

I am now wondering if introducing these new set of parameters to
pg_get_triggerdef() would be a better solution that creating a new
function. 

Doing so we keep it consistent with the other pg_get*def functions. What
do you think?



So, I am new to PG development, but I am hesitant to modify the existing `pg_get_triggerdef` or its parameters. My concern is that users may currently rely on its existing functionality and parameter structure, and altering it could introduce breaking changes. I think the naming `pg_get_trigger_ddl` is actually better than `triggerdef` because all the current `pg_get*def` implementations accept OIDs. To my knowledge, the only one that accepted an OIDs or a name is `pg_get_viewdef`, but the name variant is now deprecated.

--
Best, 
Phil Alger

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Next
From: Nathan Bossart
Date:
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()