Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement - Mailing list pgsql-hackers

From Philip Alger
Subject Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Date
Msg-id CAPXBC8+tVf=VHwA0zuzsMhvQdw8Vue9bK4pFNDDHSuWbPVzF7A@mail.gmail.com
Whole thread
In response to Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement  (Soumya S Murali <soumyamurali.work@gmail.com>)
Responses Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
List pgsql-hackers
Tree view


In support of this, I have tried testing after making a small change
in the function pg_get_trigger_ddl() in ruleutils.c:

Instead of this:
/*Parse the trigger name to handle quoted identifiers */
nameList = textToQualifiedNameList(trgName);
if (list_length(nameList) != 1)
    ereport(ERROR,
                (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
                 errmsg("trigger name cannot be schema qualified")));
 DeconstructQualifiedName(nameList, &schemaName, &objName);


Thanks for taking a look Soumya. 

I believe these DDL functions now live in ddlutils.c and include a new parameter for adding a "pretty" flag is required. I am in the middle of developing a patch for that, but I took your fix into consideration.
 
Do: objName = text_to_cstring(trgName); to treat the trigger name

I think this makes sense. 

I also will need to make a few adjustments to get the pretty printing functionality working. Since my patch essentially borrows from pg_get_triggerdef_worker, it will need some work.

--
Best,
Phil Alger

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column
Next
From: SATYANARAYANA NARLAPURAM
Date:
Subject: Re: Fix HAVING-to-WHERE pushdown with nondeterministic collations