Re: [pgadmin-hackers] Style guide live website - looking for feedback - Mailing list pgadmin-hackers

From Shirley Wang
Subject Re: [pgadmin-hackers] Style guide live website - looking for feedback
Date
Msg-id CAPG3WN50HsP81rnPS63m3TcmWtFT0fqufXdK4EHBU=TW-9d11A@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] Style guide live website - looking for feedback  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] Style guide live website - looking for feedback  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers

Looks good. A couple of thoughts:

- Please use "pgAdmin 4" consistently :-)

Just to clarify - is there always a space between pgAdmin and 4? or is it pgAdmin4? 
 
- The neutral message panel has a border that is quite visible, whilst
the others have much more subtle borders. Seems like something to fix.

It is an interesting contrast. I think it should be changed too. 

- I think we need some notes on when the different font sizes should be used.

Ok. I can start documenting where these fonts are used now, and then we can think about if that's how we actually want to use them.
 
- You've obviously created classes for these styles (e.g. text-14).
Let's make sure they are all actually defined in the stylesheets for
the app before we add the style guide :-)

Will do. 
 
Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal ServerError displayed if click on statistic tab for PG 10 server
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] Style guide live website - looking for feedback