Re: Track skipped tables during autovacuum and autoanalyze - Mailing list pgsql-hackers

From Shinya Kato
Subject Re: Track skipped tables during autovacuum and autoanalyze
Date
Msg-id CAOzEurRddqm-etFkG9T4auovYUDdB1bBasNJGg1jW09tXcOmTg@mail.gmail.com
Whole thread
In response to Track skipped tables during autovacuum and autoanalyze  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Track skipped tables during autovacuum and autoanalyze
List pgsql-hackers
Thanks for updating the patches!

On Tue, Sep 15, 2026 at 4:43 AM Sami Imseih <samimseih.pg@gmail.com> wrote:
> This is less about stats reporting and more about filtering out such
> relations earlier in expand_vacuum_rel() for manually specified
> VACUUM/ANALYZE targets. Not a big thing, but it would avoid an extra
> syscache lookup and a misleading "lock not available" warning.

I would like to fold one more case into that follow-up. The skip is
reported before vacuum_is_permitted_for_relation(), so a user with no
rights on the table can still move its counters.

The callback argument of RangeVarGetRelidExtended() looks like the
right place for all of this. It runs before the lock attempt, and the
comment there already says that is where permission checks belong. It
also hands us relId, so expand_vacuum_rel() would no longer need the
second RangeVarGetRelid(..., NoLock, true) lookup.


--
Shinya Kato
NTT OSS Center



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pgsql: Revert online data checksum transitions
Next
From: Manuel Reyes Bravo
Date:
Subject: Re: pgsql: Revert online data checksum transitions