Request a Demo
Home   >   mailing lists

Re: Add mode column to pg_stat_progress_vacuum - Mailing list pgsql-hackers

From Shinya Kato
Subject Re: Add mode column to pg_stat_progress_vacuum
Date
Msg-id CAOzEurQT9dd59au+EbXN_huX8NLYoEPZJiUxyODdUKGstViJ0Q@mail.gmail.com
Whole thread Raw
In response to Re: Add mode column to pg_stat_progress_vacuum  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Tree view 
Thank you for the review!

On Thu, Dec 4, 2025 at 9:15 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> I've attached a small change to simplify the 0001 patch. Please review it.

LGTM, and I've updated in v9 patches.

> Here are a few comments:
>
> +        <listitem>
> +         <para>
> +          <literal>manual</literal>: The analyze was started by an explicit
>
> For consistency with "started_by" in pg_stat_progress_vacuum, I think
> it's better to start with "The operation was started by".

I think "started_by" in pg_stat_progress_vacuum uses "The vacuum was
started by ...".

> ---
> +          <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command>
> +          command.
>
> How about using "... or VACUUM with the ANALYZE option"?

Agreed, I've fixed it.


--
Best regards,
Shinya Kato
NTT OSS Center
Attachment

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: Michael Paquier
Date:
Subject: Re: Improve error reporting in 027_stream_regress test