On Mon, Mar 21, 2022 at 4:36 PM Thomas Munro <thomas.munro@gmail.com> wrote: > On Sat, Feb 26, 2022 at 7:58 AM David Christensen > <david.christensen@crunchydata.com> wrote: > > Attached is V2 with additional feedback from this email, as well as the specification of the > > ForkNumber and FPW as specifiable options. > > Trivial fixup needed after commit 3f1ce973.
[04:30:50.630] pg_waldump.c:963:26: error: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘ForkNumber *’ [-Werror=format=] [04:30:50.630] 963 | if (sscanf(optarg, "%u", &config.filter_by_relation_forknum) != 1 || [04:30:50.630] | ~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [04:30:50.630] | | | [04:30:50.630] | | ForkNumber * [04:30:50.630] | unsigned int *
And now that this gets to the CompilerWarnings CI task, it looks like GCC doesn't like an enum as a scanf %u destination (I didn't see that warning locally when I compiled the above fixup because clearly Clang is cool with it...). Probably needs a temporary unsigned int to sscanf into first.
Do you need me to fix this, or are you incorporating that into a V4 of this patch? (Similar to your fixup prior in this thread?)
