Re: [PATCH v1] [BUG #19507] Prevent constraint name conflicts in partition trees spanning multiple schemas - Mailing list pgsql-hackers

From Marko Grujic
Subject Re: [PATCH v1] [BUG #19507] Prevent constraint name conflicts in partition trees spanning multiple schemas
Date
Msg-id CAOvwyF1JsmerqF6hA005rb6YLP=pQAPOJCAKnr398=0ReZG=AA@mail.gmail.com
Whole thread
List pgsql-hackers
Updating the patch with some minor refinements:
- remove redundant list_free(inheritors)
- use foreach_oid in place of foreach
- explain input args to the new ChooseConstraintNameForRelation function

Also reporting that I'm seeing this bug manifest all the way back to PG14 
(haven't looked further since versions older than that are EOLd).

Importantly, besides latest master, the current patch applies cleanly to PG18 (plain git apply).
In addition, it also applies without any conflicts to PG17, PG16 and PG15 (git apply --3way).

It doesn't apply cleanly to PG14 (missing src/test/regress/{sql, expected}/constraints.{sql, out} files),
but since its EOL is a couple of months away I don't think back-porting this to it is that important anyway.

Thanks,
Marko

Attachment

pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Heads Up: cirrus-ci is shutting down June 1st