Home > mailing lists

[PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs - Mailing list pgsql-hackers

From	Dharin Shah
Subject	[PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
Date	December 28 00:09:14
Msg-id	CAOj6k6d0YO6AO-bhxkfUXPxUi-+YX9-doh2h5D5z0Bm8D2w=OA@mail.gmail.com Whole thread Raw
List	pgsql-hackers

Hello,

and this line

- The number of lexemes must be less than 2^64

Docs wrongly claim "lexemes must be < 2^64" but the actual constraint is
1 MB total storage (MAXSTRPOS), and no 2^64 check exists in the code.

From src/include/tsearch/ts_type.h:

#define MAXSTRPOS ( (1<<20) - 1) // 1,048,575 bytes

typedef struct {
int32 size; // number of lexemes
...
} TSVectorData;

The attached patch:

- Removes the incorrect 2^64 claim
- Clarifies this means "distinct lexemes in a single tsvector value"

Thanks,
Dharin

From: Daniel Gustafsson
Date: 27 December, 23:37:41
Subject: Re: Missing oauth_validator_libraries in variable_is_guc_list_quote()

From: Daniel Gustafsson
Date: 28 December, 00:14:49
Subject: Re: Fix typos: 'Bejing' to 'Beijing' in partition regress/docs