Re: [PATCH] improve the pg_upgrade error message - Mailing list pgsql-hackers

From Jeevan Ladhe
Subject Re: [PATCH] improve the pg_upgrade error message
Date
Msg-id CAOgcT0NaCLcpnoKmAF3KHxFXv570+WAuvaErNOgDMOCtktDbOA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] improve the pg_upgrade error message  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] improve the pg_upgrade error message  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Hi Daniel,

Was wondering if we had any barriers to getting this committed.
I believe it will be good to have this change and also it will be more in line
with other check functions also.

Regards,
Jeevan

On Thu, Oct 21, 2021 at 3:51 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 14 Jul 2021, at 07:27, Suraj Kharage <suraj.kharage@enterprisedb.com> wrote:

> Overall patch looks good to me.

Agreed, I think this is a good change and in line with how the check functions
work in general.

> Instead of giving suggestion about updating the pg_database catalog, can we give "ALTER DATABASE <datname> ALLOW_CONNECTIONS true;" command?

I would actually prefer to not give any suggestions at all, we typically don't
in these error messages.  Since there are many ways to do it (dropping the
database being one) I think leaving that to the user is per application style.

> Also, it would be good if we give 2 spaces after full stop in an error message.

Correct, fixed in the attached which also tweaks the language slightly to match
other errors.

I propose to commit the attached, which also adds a function comment while
there, unless there are objections.

--
Daniel Gustafsson               https://vmware.com/

pgsql-hackers by date:

Previous
From: "osumi.takamichi@fujitsu.com"
Date:
Subject: RE: Failed transaction statistics to measure the logical replication progress
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] improve the pg_upgrade error message