Postgres Pro
Downloads
Home   >   mailing lists

Re: concerns around pg_lsn - Mailing list pgsql-hackers

From Jeevan Ladhe
Subject Re: concerns around pg_lsn
Date
Msg-id CAOgcT0MTVCXbiOH_peHuoSemXE8Z6AkatZAJkjS-1Kjq6Sz0QQ@mail.gmail.com
Whole thread Raw
In response to Re: concerns around pg_lsn  (Michael Paquier <michael@paquier.xyz>)
Responses Re: concerns around pg_lsn  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view
On Sun, Aug 4, 2019 at 12:13 PM Michael Paquier <michael@paquier.xyz> wrote:
On Sat, Aug 03, 2019 at 11:57:01PM -0400, Alvaro Herrera wrote:
> Can we please change the macro definition so that have_error is one of
> the arguments?  Having the variable be used inside the macro definition
> but not appear literally in the call is quite confusing.

Can't agree more. This is where I also got confused initially and thought
the flag is unused.

Good idea.  This needs some changes only in float.c.

Please find attached patch with the changes to RETURN_ERROR and
it's references in float.c

Regards,
Jeevan Ladhe 
Attachment

pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: Fix typos and inconsistencies for HEAD (take 9)
Next
From: Amit Kapila
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs