Request a Demo
Home   >   mailing lists

Re: Remove unused function parameters, part 1: contrib - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: Remove unused function parameters, part 1: contrib
Date
Msg-id CAOYmi+mJHqosCVOwP=K=oyrVszLetsOnYmYGrj9fR2seTauP8w@mail.gmail.com
Whole thread Raw
In response to Re: Remove unused function parameters, part 1: contrib  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Nov 27, 2025 at 4:13 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
> This function is already exercised with the tests added in f2464997644c so that
> looks ok to me.
>
> Maybe Jacob or Andrew have some thoughts to share?

Ooh, blast from the past! You've found my very first Postgres review.
I do not remember it at all. :D

Your v2-0005 looks more correct (and less confusing) to me. I'm not
qualified to comment on the historical behavior of citext+collations.

--Jacob

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Remove useless casting to the same type
Next
From: Álvaro Herrera
Date:
Subject: Re: split tablecmds.c