Re: Serverside SNI support in libpq - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: Serverside SNI support in libpq
Date
Msg-id CAOYmi+m+Om21ej2tf6xu6zRr2dBaddyodC0JG0i5aCH6NR74fA@mail.gmail.com
Whole thread
In response to Re: Serverside SNI support in libpq  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Serverside SNI support in libpq
List pgsql-hackers
On Wed, Mar 18, 2026 at 7:25 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> The longfin issue is a bit more odd, I can reproduce it on macOS with OpenSSL
> 1.1.1 but nowhere else.  Rather than reporting an SSL error for aborted
> handshake it reports a SYSCALL error.

Do you know yet why the handshake is aborted on macOS, as opposed to a
polite handshake_failure alert?

> The change in the attached diff does fix it for me but I'm
> a bit hesitant to apply something like that, I would be more inclined to the
> change the expected output in the test.  What are your thoughts?

I think that patch might effectively shadow the `else` branch, which
is supposed to be reporting the EOF. (I wouldn't mind a better error
message than "SYSCALL error: EOF detected", but that's not something
this patch did.)

--Jacob



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: another autovacuum scheduling thread
Next
From: Artur Zakirov
Date:
Subject: Order of InvokeObjectPostAlterHook within ATExecSetNotNull