Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times
Date
Msg-id CAOYmi+=ezP7DSyTKh9xy3ejTxydrVicBYBYeoVZOWgYvAyjDxA@mail.gmail.com
Whole thread
In response to Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times
List pgsql-hackers
On Wed, Apr 22, 2026 at 12:23 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I agree that we have no real ability to guarantee that.
> Still, as far as the presented patch goes, it seems like a clear
> win so I'd vote for fix-and-backpatch.

Sounds good to me.

> Should we write the arguments as BIO_TYPE_NONE | BIO_TYPE_SOURCE_SINK
> rather than just BIO_TYPE_SOURCE_SINK?

Good question... Popularity-wise, the shorter spelling shows up across
quite a few projects on GitHub, but the only spelling of
`BIO_meth_new(BIO_TYPE_NONE | ...)` that I can find is a single place
inside OpenSSL's own test suite -- which also uses the shorter
alternative, in two places. So my vote is BIO_TYPE_SOURCE_SINK; we'll
be in good company.

Thanks,
--Jacob



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times
Next
From: Tom Lane
Date:
Subject: Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times