Re: pg_walinspect: fix LSN validation messages and empty range handling - Mailing list pgsql-hackers

From surya poondla
Subject Re: pg_walinspect: fix LSN validation messages and empty range handling
Date
Msg-id CAOVWO5rS47aFciEtwg3zTnp+DQn8TAm2eo1aSCSNbv=eBNGD-g@mail.gmail.com
Whole thread
In response to Re: pg_walinspect: fix LSN validation messages and empty range handling  (Xuneng Zhou <xunengzhou@gmail.com>)
List pgsql-hackers
Hi Chao,

Thanks for the v5 patch (all the points that were earlier raised were addressed). Both patches apply with git am, the build is clean with no new warnings.

I also checked that advancing the origin doesn't leak into the rest of
subscription.sql: no later test sets a skip LSN with a valid location, and the
new block leaves subskiplsn reset to NONE, so nothing downstream depends on the origin position.

No further comments from me, v5 looks ready for a committer. You can create a commitfest entry for this.

Regards,
Surya Poondla

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Adding a range check on the sequence index from the publisher.
Next
From: Konstantin Knizhnik
Date:
Subject: RE: Recovery at replica stuck because recovery incorrectly trusts an old high-water mark