Request a Demo
Home   >   mailing lists

Re: Add comments about fire_triggers argument in ri_triggers.c - Mailing list pgsql-hackers

From surya poondla
Subject Re: Add comments about fire_triggers argument in ri_triggers.c
Date
Msg-id CAOVWO5q8cfbHiZuL-wSxknnriPCBYpqRCnQKfH38WuLwFuxkSw@mail.gmail.com
Whole thread Raw
In response to Add comments about fire_triggers argument in ri_triggers.c  (Yugo Nagata <nagata@sraoss.co.jp>)
List pgsql-hackers
Tree view
Hi Yugo,

Your patch change looks good.

Yes Amit, I agree that SPI_execute_snapshot() comments do provide some context on AFTER triggers, but I still feel the newly added comment in ri_PerformCheck() gives additional context on why the fire_triggers is set to false.

Regards,
Surya Poondla

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: psql: make %P prompt option consistent when not connected
Next
From: Heikki Linnakangas
Date:
Subject: Re: Interrupts vs signals