Hi Brian,
On Sun, Jan 12, 2025 at 4:47 AM Brian Cosgrove <cosgroveb@gmail.com> wrote:
>
> Unrelated to autopkgtest, I noticed in October that during debbuild
> the package does not run the main pytest suite for pgbouncer? Is that
> intentional? It appears that before the tests were rewritten in python
> that the package ran the shell-based suite properly.
Looking at the history for d/rules, I think disabling the main test
suite during the build was intended to be a temporary fix for a missing
file in the upstream source archive [0],[1]. It looks like the tests
weren't re-enabled when the issue was fixed upstream.
> I submitted a patch that should be able to be incorporated as-is:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085109
I've applied your patch to the package and pushed the changes to Salsa.
I did have to drop the b-d on python3-contextlib2 since this package is
not available (and not needed) in unstable. I also had to add
tzdata-legacy in order for the tests to pass. We'll probably need to add
some tweaks for the pgdg packages to build on older distributions.
[0]: https://salsa.debian.org/postgresql/pgbouncer/-/commit/74f05a0#8756c63497c8dc39f7773438edf53b220c773f67_22_25
[1]: https://github.com/pgbouncer/pgbouncer/issues/431
