Re: pgbench - allow to store select results into variables - Mailing list pgsql-hackers

From Rafia Sabih
Subject Re: pgbench - allow to store select results into variables
Date
Msg-id CAOGQiiOsSDqq0LAqw+=bWtZK+N4-XBjx-_d+ijwax823+ftAYQ@mail.gmail.com
Whole thread Raw
In response to Re: pgbench - allow to store select results intovariables  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench - allow to store select results intovariables
List pgsql-hackers
On Fri, Mar 24, 2017 at 8:59 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>
> Hello Rafia,
>
>> if (my_command->argc > 2)
>> + syntax_error(source, lineno, my_command->line, my_command->argv[0],
>> + "at most on argument expected", NULL, -1);
>>
>> I suppose you mean 'one' argument here.
>
>
> Indeed.
>
>> Apart from that indentation is not correct as per pgindent, please check.
>
>
> I guess that you are refering to switch/case indentation which my emacs does
> not do as expected.
>
> Please find attached a v8 which hopefully fixes these two issues.
Looks good to me, marking as ready for committer.
-- 
Regards,
Rafia Sabih
EnterpriseDB: http://www.enterprisedb.com/



pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Radix tree for character conversion
Next
From: Arjen Nienhuis
Date:
Subject: example for xmltable with XMLNAMESPACES