Re: Extended statistics improvement: multi-column MCV missing values - Mailing list pgsql-hackers

From Enrique Sánchez
Subject Re: Extended statistics improvement: multi-column MCV missing values
Date
Msg-id CAOCkzAnpimojq1=+KqdVco37K9v0TiDgC2uQ+QBNfkDcjR0Gqg@mail.gmail.com
Whole thread
In response to Re: Extended statistics improvement: multi-column MCV missing values  (Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>)
Responses Re: Extended statistics improvement: multi-column MCV missing values
List pgsql-hackers
Hi,

On 15/06/26 23:13, Ilia Evdokimov wrote:

It's generally not safe to compare floating-point values for equality. I mean using `mcv_sel == 0.0` to detect that there are no extended MCV matches. IMO, we should use a bool variable (similar to how var_eq_const() does it) to track whether any MCV item matched, specifically in the loop where we check extended MCV matches in mcv_clauselist_selectivity().

Makes sense, I've fixed it in v5-0002.

I've also created a commit fest entry for this patch: https://commitfest.postgresql.org/patch/6898/ 

Best regards,
Enrique.
Attachment

pgsql-hackers by date:

Previous
From: surya poondla
Date:
Subject: Re: Improving psql autocompletion for SET LOCAL / SET SESSION
Next
From: Chao Li
Date:
Subject: Re: Make frontend programs relink after libpgfeutils changes