Re: Extended statistics improvement: multi-column MCV missing values - Mailing list pgsql-hackers

From Enrique Sánchez
Subject Re: Extended statistics improvement: multi-column MCV missing values
Date
Msg-id CAOCkzAkE=tgZsH71YRLF-dPsAR8Mjyr3QWYsMAjsVXGxZxZ1eg@mail.gmail.com
Whole thread
In response to Extended statistics improvement: multi-column MCV missing values  (Enrique Sánchez <enriqueesanchz@gmail.com>)
Responses Re: uuidv7 improperly accepts dates before 1970-01-01
List pgsql-hackers
Hi Ilia, thanks for the review!

I've fixed the cosmetic nits in v7 and attached it to the next email.

Best regards,
Enrique.

On, 24 Jul 2026 at 17:03, Ilia Evdokimov (<ilya.evdokimov@tantorlabs.com>) wrote:
The overall approach looks architecturally correctly. Just two cosmetic
nits:

1. In `mcv_can_cap()`, the early-exit branch uses braces around `return
false`. This would normally be written without braces.

2. The doc comment above `mcv_can_cap()` says condition requires the
clause to be either an  equality operator, or a bare boolean Var, but
implementation actually handles one more cases - `NOT var`

3. Apply pgindent into diff.
Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: PSQL schema "describe" \dn is not escaping quotes
Next
From: Michael Paquier
Date:
Subject: Re: lost lock during toasting allows fk violation