Home > mailing lists

Patch for SonarQube fixes. - Mailing list pgadmin-hackers

From	Nikhil Mohite
Subject	Patch for SonarQube fixes.
Date	January 18, 2021 08:45:39
Msg-id	CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com Whole thread Raw
Responses	Re: Patch for SonarQube fixes.
List	pgadmin-hackers

Hi Team,

I have fixed a few sonarQube issues, PFA patch

Details as follows:

1. Preferences:

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
Merge this if statement with the enclosing one.
Define a constant instead of duplicating this literal 'tab settings' 5 times.

2. Connection:

Remove this unneeded "pass".

3. Sqleditor:

Remove this useless assignment to variable "msgDiv".

4. Debugger:

Review this useless assignment: "index" already holds the assigned value along all execution paths.
'label' is already declared in the upper scope.
'label' is already declared in the upper scope.
'browser_preferences' is already declared in the upper scope.

5. FileManager:

'path' is already declared in the upper scope.

--

Thanks & Regards,

Nikhil Mohite

Software Engineer.

EDB Postgres

Mob.No: +91-7798364578.

Attachment

SonarQubeCodeSmellFixes.patch

pgadmin-hackers by date:

Previous

From: Aditya Toshniwal
Date: 18 January 2021, 08:03:32
Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta)

Next

From: Khushboo Vashi
Date: 18 January 2021, 10:30:37
Subject: Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1