Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql:Support FETCH FIRST WITH TIES) - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql:Support FETCH FIRST WITH TIES)
Date
Msg-id CAOBaU_btWJCLb1wg11qETg5ro833za5sDWL0vhPuNi7rQ8DtdQ@mail.gmail.com
Whole thread Raw
In response to Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, May 11, 2020 at 3:41 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Julien Rouhaud <rjuju123@gmail.com> writes:
> > Note that timezone/zic.c would also have to be changed.
>
> Why?  It uses "fallthrough" which is a legal spelling per level 4.

GCC documentation mentions [ \t]*FALLTHR(OUGH|U)[ \t]* for level 4
(out of the view other alternatives), which AFAICT is case sensitive
(level 3 has fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)?).



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)
Next
From: Tom Lane
Date:
Subject: Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)