Re: reindexdb & clusterdb broken against pre-7.3 servers - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: reindexdb & clusterdb broken against pre-7.3 servers
Date
Msg-id CAOBaU_Yra0iFrJpCt+kL1ZKYKuHbU8yqnLpeBMy7LXJ15pJG5w@mail.gmail.com
Whole thread Raw
In response to Re: reindexdb & clusterdb broken against pre-7.3 servers  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: reindexdb & clusterdb broken against pre-7.3 servers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, May 6, 2019 at 3:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Michael Paquier <michael@paquier.xyz> writes:
> > On Mon, May 06, 2019 at 08:32:44AM -0400, Andrew Dunstan wrote:
> >> Why do we even have code referring to pre-7.3 servers? Wouldn't it be
> >> simpler just to remove that code?
>
> > Even for pg_dump, we only support servers down to 8.0.  Let's nuke
> > this code.
>
> +1.  I think psql claims to support down to 7.4, but that's still not
> a precedent for trying to handle pre-7.3.  Also, the odds that we'd
> not break this code path again in future seem pretty bad.

WFM.  Updated patch attached, I also removed another similar chunk in
the same file while at it.

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs
Next
From: Tom Lane
Date:
Subject: Re: reindexdb & clusterdb broken against pre-7.3 servers