Re: Suggestion to add --continue-client-on-abort option to pgbench - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Re: Suggestion to add --continue-client-on-abort option to pgbench
Date
Msg-id CAO6_Xqq4OyDVu0BKt_kLz3nuKE-_sjCPDL7YUmSVuB4zcPt9tQ@mail.gmail.com
Whole thread Raw
In response to Re: Suggestion to add --continue-client-on-abort option to pgbench  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Suggestion to add --continue-client-on-abort option to pgbench
List pgsql-hackers
Hi,

The patch looks good, I've spotted some typos in the doc.

+        Allows clients to continue their run even if an SQL statement
fails due to
+        errors other than serialization or deadlock. Unlike
serialization and deadlock
+        failures, clients do not retry the same transactions but
start new transaction.

Should be "but start a new transaction.", although "proceed to the
next transaction." may be clearer here that ?

+       number of transactions that got a SQL error
+       (zero unless <option>--failures-detailed</option> is specified)

It seems like both "a SQL" and "an SQL" are used in the codebase and
doc, but this page only uses "an SQL", so using "an SQL" may be better
for consistency.

+   If an SQL command fails due to serialization or deadlock errors, the
+   client does not aborted, regardless of whether

Should be "the client does not abort."

Regards,
Anthonin Bonnefoy



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Optimize LISTEN/NOTIFY
Next
From: Richard Guo
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master