Request a Demo
Home   >   mailing lists

Re: Don't keep closed WAL segment in page cache after replay - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Re: Don't keep closed WAL segment in page cache after replay
Date
Msg-id CAO6_XqoDPt9+VOGkVHx5QsaBZjL7OQVhnkwb+rmtRq3pdm-ojw@mail.gmail.com
Whole thread
In response to Re: Don't keep closed WAL segment in page cache after replay  (Japin Li <japinli@hotmail.com>)
Responses Re: Don't keep closed WAL segment in page cache after replay
List pgsql-hackers
Tree view 
On Wed, Mar 4, 2026 at 2:40 AM Japin Li <japinli@hotmail.com> wrote:
> Both "Return ..." and "Returns ..." styles exist in the PostgreSQL codebase,
> but within the same patch, would it be better to use a consistent style?

That makes sense, I've updated the comment. I think I usually look
around the code to copy the comments' style, but as you said, both are
present in PostgreSQL codebase.

Regards,
Anthonin Bonnefoy
Attachment

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance
Next
From: Alexander Lakhin
Date:
Subject: Re: BUG: Former primary node might stuck when started as a standby