Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint - Mailing list pgadmin-hackers

Hi Akshay,

Please find the attached updated patch.

On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

Test case are working fine, some minor review comments:

• Scenario name "Create/Alter Exclusion Constraint" repeating twice instead of that it should be more understandable.
• File name should not be like "create/alter_exclusion_constraint_1.sql" it should be like 'alter_comment.sql'.

Fixed.

Thanks,

Khushboo 

On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch for the RE-SQL tests of the Exclusion constraint node with some bug fixes in SQL.

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246