Re: [pgAdmin][RM6177] ERD download image related fixes - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM6177] ERD download image related fixes
Date
Msg-id CANxoLDfxVugTihpCJDGJGopdUy3OBBD3weD_7PadximeGfMNBw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM6177] ERD download image related fixes  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Fri, Jan 29, 2021 at 12:05 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

Attached is the patch based on the latest code base.

On Fri, Jan 29, 2021 at 11:58 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

I think you forgot to attach the patch.

On Thu, Jan 28, 2021 at 4:35 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Icons were not visible in downloaded images. Fixed.
2) Download image will now work on Safari and Firefox also.
3) Added the icon of foreign key to the "many" endpoint of one to many links.
image.png

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue while downloading ERD images in Safari
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Implemented runtime using NWjs to open pgAdmin4 in a