Hi Nagesh, Done the changes as you suggested, please find attached patch for same. Also coping pgadmin-hackers for integration. Thanks & feel free to let me know, if missed anything. Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com From: Nagesh Dhope <nagesh.dhope@enterprisedb.com>Date: Wednesday, 1 July 2020 at 10:57 AMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Postgres Enterprise Manager <pem@enterprisedb.com>Subject: Re: CSS SonarQube fixes Hi Pramod, Remove commented styles from below files.web/pgadmin/misc/file_manager/static/css/file_manager.cssweb/pgadmin/misc/file_manager/static/scss/_file_manager.scssweb/pgadmin/misc/static/explain/scss/_explain.scss Apart from this, the patch looks good. Please send the updated patch to pgadmin-hackers@postgresql.org. On Tue, Jun 30, 2020 at 4:44 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:Hi Team,I am reviewing this patch. On Mon, Jun 29, 2020 at 4:54 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:Hi Team, Please find few CSS fixes for SonarQube. It consists below types of issues: Duplicate CSS removalFew standard syntax applied on classesDouble semicolon removalOther minor Had tested at my end, & verified. Please do let me know if missed anything thanks ! Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com -- Thanks,Nagesh -- Thanks,Nagesh
Hi Nagesh,
Done the changes as you suggested, please find attached patch for same.
Also coping pgadmin-hackers for integration.
Thanks & feel free to let me know, if missed anything.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
From: Nagesh Dhope <nagesh.dhope@enterprisedb.com>Date: Wednesday, 1 July 2020 at 10:57 AMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Postgres Enterprise Manager <pem@enterprisedb.com>Subject: Re: CSS SonarQube fixes
Hi Pramod,
Remove commented styles from below files.
web/pgadmin/misc/file_manager/static/css/file_manager.cssweb/pgadmin/misc/file_manager/static/scss/_file_manager.scssweb/pgadmin/misc/static/explain/scss/_explain.scss
Apart from this, the patch looks good. Please send the updated patch to pgadmin-hackers@postgresql.org.
On Tue, Jun 30, 2020 at 4:44 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi Team,I am reviewing this patch. On Mon, Jun 29, 2020 at 4:54 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:Hi Team, Please find few CSS fixes for SonarQube. It consists below types of issues: Duplicate CSS removalFew standard syntax applied on classesDouble semicolon removalOther minor Had tested at my end, & verified. Please do let me know if missed anything thanks ! Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com -- Thanks,Nagesh
Hi Team,
I am reviewing this patch.
On Mon, Jun 29, 2020 at 4:54 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi Team, Please find few CSS fixes for SonarQube. It consists below types of issues: Duplicate CSS removalFew standard syntax applied on classesDouble semicolon removalOther minor Had tested at my end, & verified. Please do let me know if missed anything thanks ! Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com
Please find few CSS fixes for SonarQube.
It consists below types of issues:
Had tested at my end, & verified. Please do let me know if missed anything thanks !
--
Thanks,
Nagesh
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных