Re: Sonarqube fixes - test_utils.py - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Sonarqube fixes - test_utils.py
Date
Msg-id CANxoLDfiEuigW9Hjiizva1WO3O5=3_mvTwRjVv7bHacovrYYJw@mail.gmail.com
Whole thread Raw
In response to Re: Sonarqube fixes - test_utils.py  (Shubham Agarwal <shubham.agarwal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Fri, Jul 31, 2020 at 12:07 PM Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,
Attached is the patch to fix all the Sonar Qube related errors in test_utils.py

On Thu, Jul 30, 2020 at 4:37 PM Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Murtuza,
I will check and send the fix.

On Thu, Jul 30, 2020, 4:07 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
-- pgadmin-hackers
++ PEM

Hi Shubham,

Reviewed & Committed, But sonarlint is showing 7 other issues in this file apart from this bug fix.

image.png

On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,
Attached is the patch containing a fix for the SonarQube Bug in the test_utils.py file.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column
Next
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch] - SonarQube Fixes