Re: Feature #5370 User should be able to set the binary path for each database server - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Feature #5370 User should be able to set the binary path for each database server
Date
Msg-id CANxoLDfe8H-E9qmO1KYiRVodpBRWPcEmxKKKwPXQ4MDShE9XPQ@mail.gmail.com
Whole thread Raw
In response to Re: Feature #5370 User should be able to set the binary path for each database server  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: Feature #5370 User should be able to set the binary path for each database server  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Aditya/Hackers

Screenshot 2021-05-13 at 3.02.59 PM.png

Are the above changes looks good? 


On Thu, May 13, 2021 at 2:43 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Just to make it more discoverable, please also change the help text in Preferences dialog.

On Thu, May 13, 2021 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave/Hackers

I have implemented feature #5370 "User should be able to set the binary path for each database server." I have added "Utility path" control in the Advanced tab of the server dialog, refer to the image below:

                          Screenshot 2021-05-13 at 2.11.52 PM.png

If the above path is set by the user then will pick that else we will pick the default binary path of the preferences dialog (if set). In case utility is not found on the specified path we raise the popup dialog with the modified error message. 

                         Screenshot 2021-05-13 at 2.12.28 PM.png

If the above implementation looks good then, I'll commit this feature by today's EOD.

--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch] - RM #6444 and #6445
Next
From: Dave Page
Date:
Subject: Re: Feature #5370 User should be able to set the binary path for each database server