Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment
Date
Msg-id CANxoLDf_ZfeECUA1XQcAJOPHs1E7eWC7=bThdAbGdqxxTotK2w@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi Khushboo

Why there are two identical functions (def get_my_ip) in two different files, can you please make it generic in one place only and send the patch.

On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and IPv6 respectively.
 
Thanks,
Yogesh Mahajan
EnterpriseDB


On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the default Public IP range issue in AWS deployment.

@Yogesh Mahajan, please test.


Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Yogesh Mahajan
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment