Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window
Date
Msg-id CANxoLDfA4NnprMEhYtPj9JTDG036L5VOed3Lpk-C20xn0bXSsg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
Responses Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Aug 27, 2020 at 8:16 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Please find the update patch attached here.

On Thu, Aug 27, 2020 at 8:10 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch below which adds the functionality of the query tool button in the query tool sqleditor.

Acceptance criteria:
- For sqleditor on same window & on new tab:
  • When a query tool connection is initiated, as expected it will open the connection based on the selected database in the treeview. Now, when the user clicks the query tool connection button on the query tool window, irrespective of the selected database in treeview, it should open a connection based on the query tool connected database.
  • Similarly, for a new tab, clicking on the query tool connection button, it should open a connection based on the query tool connected database, instead of selected treeview node.
query tool button.png

Additionally, an error is handled in the form of message dialog prompting the user to initiate the connection, when sqleditor is opened in the new tab with the main application window kept closed. This can be reviewed by refreshing the window as well as clicking on the query tool connection button.

A prompt dialog message box is seen as:

Screen Shot 2020-08-27 at 8.04.33 PM.png

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][Patch] RM5426 - [pgagent]: Codemirror control height should use maximum space while creating jobstep
Next
From: Cyril Jouve
Date:
Subject: More idiomatic python3 + fix some tests