Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze
Date
Msg-id CANxoLDf7HmHSLePRbnfgU3=pt4KmZnAdsVdiUBhC2pBe7_W9aw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze
List pgadmin-hackers
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Improve the explain plan details by showing popup ins
Next
From: Nikhil Mohite
Date:
Subject: [pgAdmin][RM-6075]: Non-admin user is unable to view shared server created using 'Service'.