Re: Fixed FB 20417 - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Fixed FB 20417
Date
Msg-id CANxoLDf5VGFRaOLunSH9Hn3HbL9Y2vnVc3qKdkxUiYHwjJp2aQ@mail.gmail.com
Whole thread Raw
In response to Re: Fixed FB 20417  (Dave Page <dpage@pgadmin.org>)
Responses Re: Fixed FB 20417  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Hi Dave

Modified the logic. Attached is the patch file, please review it.

On Mon, Jan 9, 2012 at 6:04 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jan 9, 2012 at 11:23 AM, Akshay Joshi
<akshay.joshi@enterprisedb.com> wrote:
> Hi Dave
>
> I have fixed the Fogbugz 20417 "PEM client: Unable to remove comments on
> slony Replication(edb_cluster) tab". Attached is the patch file, please
> review it.

Hi,

I think the patch is basically correct, but needs a small mod so it
only appends the comment change if the user has actually changed it
from the existing value to something else.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: "pgAdmin Trac"
Date:
Subject: Re: [pgAdmin III] #342: Enumerable type doesn't have all the options available on CREATE TYPE
Next
From: Guillaume Lelarge
Date:
Subject: Re: Fixed FB 20417