Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] [RM# 3290] Close button missing for the message windowfrom the backend server - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [PATCH] [RM# 3290] Close button missing for the message windowfrom the backend server
Date
Msg-id CANxoLDezCbK1Ucg=+EXBUTrTanweb8n4cuPvjQLsL3eei=JxbQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] [RM# 3290] Close button missing for the message windowfrom the backend server  (Dave Page <dpage@pgadmin.org>)
Responses Re: [PATCH] [RM# 3290] Close button missing for the message windowfrom the backend server
List pgadmin-hackers
Tree view


On Tue, Apr 24, 2018 at 1:47 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review/commit this please?

   Sure. 

Thanks.

On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo <aemengo@pivotal.io> wrote:
Just manually verified that this worked, and the patch successfully went through our pipelines.

Thanks so much for fixing this issue!

- Joao and Anthony

On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Team,

Please find the patch for fixing the RM #3290.
The 'Close button' was missing in the message box, which shows the error in the backend server.

This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel' buttons in different modules.

Please review. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout
Next
From: Akshay Joshi
Date:
Subject: Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306