Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkboxonly selects the first 50 tables - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkboxonly selects the first 50 tables
Date
Msg-id CANxoLDexDWFKP4NfdJY7cvUzn+jKJpnppoHjvwQ4MaaDE-KHeg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkboxonly selects the first 50 tables  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Mon, Jun 15, 2020 at 6:58 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find an updated patch.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Yogesh,
this.data.splice is not required as you are adding the entire dataset into collection.
Thanks,
Khushboo

On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find attached patch fixing behaviour on checking  select-all checkbox from properties tab for more than 50 entities.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube