Hi,Verification has been completed, now you can commit this patch.On Wed, Dec 4, 2019 at 2:16 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi DaveI have reviewed the code and tested the basic scenario. The code looks good to me. I have verified that the user is pgadmin with user id 5050.With your patch Without applying your patch @Fahar please test upgrades mostly when using mapped storage or session data.On Wed, Dec 4, 2019 at 8:21 AM Dave Page <dpage@pgadmin.org> wrote:The attached patch fixes $SUBJECT. I'm a little concerned about upgrades though, mostly when using mapped storage or session data. Fahar, can you test such scenarios please?Patch review is also needed please :-)-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246-- Fahar AbbasQMGEnterpriseDB CorporationPhone Office: +92-51-835-8874Phone Direct: +92-51-8466803Mobile: +92-333-5409707Skype ID: live:fahar.abbasWebsite: www.enterprisedb.com
Hi DaveI have reviewed the code and tested the basic scenario. The code looks good to me. I have verified that the user is pgadmin with user id 5050.With your patch Without applying your patch @Fahar please test upgrades mostly when using mapped storage or session data.On Wed, Dec 4, 2019 at 8:21 AM Dave Page <dpage@pgadmin.org> wrote:The attached patch fixes $SUBJECT. I'm a little concerned about upgrades though, mostly when using mapped storage or session data. Fahar, can you test such scenarios please?Patch review is also needed please :-)-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
The attached patch fixes $SUBJECT. I'm a little concerned about upgrades though, mostly when using mapped storage or session data. Fahar, can you test such scenarios please?Patch review is also needed please :-)-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных