We are making assumption here that all user's service file has port & username inside them.
What if they are not present?
5432 is the default port and the system user is the default user to connect. If port and username are not provided in the service file then the user can specify that in the dialog itself.
If I remember correctly those validation were left intentional when we added service field just to make sure that we connect to DB server from pgAdmin4 regardless of those information present in service file.
I personally think that behaviour is wrong if my service file has the correct port number then why should the user enter all those information again, and what if the user provides the wrong port number from server dialog, it trys to connect to the wrong port.
One small suggestion such comments should come early as I have sent the patch 4 days ago not after the patch has been committed.
Attached is the patch to fix the RM #4642 "port should not be mandatory when a service is provided". Cyril Jouve has sent the initial patch, but that only removes the validation on GUI, when we save the server properties without port and username backend throws an error because port and username is NOT NULL columns in the server table in SQLite.
I have removed the NOT NULL constraint from the port and username. The maintenance database is required as our whole connection logic is based on that, so I have added the NOT NULL constraint for that column.
From:
Khushboo Vashi Date: Subject:
[pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index &4624 - RE-SQL/MSQL test cases for Primary Keys
Есть вопросы? Напишите нам!
Соглашаюсь с условиями обработки персональных данных
✖
By continuing to browse this website, you agree to the use of cookies. Go to Privacy Policy.