Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers.
Date
Msg-id CANxoLDei1YA2uyPrTvmY2+GC+Yk90WSsb2YrJsSfgTZyysCEkA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Khushboo

Following are the review comments:
  • Copy with headers not working when we select a few rows.
  • The dropdown should be disabled when the copy button is disabled.
  • When user select/de-select "Copy with headers" option dropdown should not be closed. It should be consistent with "Auto Commit/Rollback" or explain options.
  • Feature test "CopySelectedQueryResultsFeatureTest" failed on my machine.
  • Documentation changes are required, update the screenshot wherever applicable. 

On Mon, Sep 23, 2019 at 11:42 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #3009 - Right click to copy from data grid, optionally with headers.

Query Tool / View data:

Currently the result-set can be copied without header. With this patch the result-set can be copied with the header also and that is optional.

To copy the result-set with header, the option 'Copy with header' is given next with the Copy button in the toolbar in the form of dropdown.

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM4756] pgAdmin does not load completely if loaded inan iframe
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid,optionally with headers.