Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explainpanel in query tool - Mailing list pgadmin-hackers

Hi Akshay,

Please find a fix for two issues reported by QA team,

- Show focus when the Tab key is pressed

- Pressing the Enter key on C:\ drive does not open it on Windows

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 31, 2020 at 11:45 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Akshay,

PFA updated patch.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Ganesh

Following are the review comments:

• Focus is going on Table headers but it is not visible.
• Need to handle keyboard events on table header for sorting.
• Add tabindex property for the table rows.
• Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue

Kindly review.

Regards,

Ganesh Jaybhay

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246