Re: [pgAdmin][RM5115] RULE SQL incorrectly generated - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5115] RULE SQL incorrectly generated
Date
Msg-id CANxoLDePRTHLUbavZnFALsw7Ny8hBKLAbAX8X_tmjBA1KD0MaA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5115] RULE SQL incorrectly generated  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Fri, Feb 21, 2020 at 3:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the SQL parsing issue in rules. The command and statements were parsed incorrectly.
Also fixed issue where removing command or statements altogether was not generating modified SQL and so was not saving.
Test cases added and changed accordingly.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fix an issue where command and statements were parsed
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Ensure that AlertifyJS should not be visible as a tit