Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to aninvisible label where a visible label cannot be used - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to aninvisible label where a visible label cannot be used
Date
Msg-id CANxoLDeOaJWOu91=ngskhNiWsheja=ZgzNeA7Lw9B=n3GWhf+w@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to aninvisible label where a visible label cannot be used  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Wed, Dec 4, 2019 at 3:00 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the feature tests which were failing after the commit. The reason being, the span elements which was used to show properties tab data is changed to input now as per accessibility requirements. Also, there is no way now to check XSS of input because the input tags returns the original value on extracting the value attribute and not the escaped value. Previously, the value was HTML element under the span tag.
Not to worry, input is escaped and is XSS free, handled in underscore templates.

On Tue, Dec 3, 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Dec 3, 2019 at 11:39 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add label and aria-label wherever applicable. The patch also fixes few other accessibility related errors raised by "WAVE" extension of Chrome.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fix the feature tests which were failing after the ac
Next
From: Akshay Joshi
Date:
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the