Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support inschema diff - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support inschema diff
Date
Msg-id CANxoLDeJyaiODhYo1ekWe+mL12gXYEScGjRfY6V6q1a3ioH8JQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Responses Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff
List pgadmin-hackers
Hi Pradip

Following are the review comments:
  • For function arguments please make sure the right sequence is gid, sid, did, scid, <object-id> ... All the parameters are not compulsory but the parameters should be in the mentioned order for consistency. Change it to all the functions of RLS Policy wherever not followed, revisit the already committed code as well.
  • In case of more than one policy, all the headers are showing as a comment on top of policy DDL in schema diff.
  • If the policy event is different for source and target policy then it is showing different but no diff SQL has been generated.
  • Created new RM #5631, fixed that to test schema diff further.

On Thu, Jun 25, 2020 at 7:38 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for RLS policy support in schema diff.

--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Reg-RM 5326[Code Coverage] Improve API test cases for Domain andDomain Constraints
Next
From: Paresh More
Date:
Subject: Patch for Redmine Bug 5630