Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Load/Save file in query tool - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch]: Load/Save file in query tool
Date
Msg-id CANxoLDe1GRMAXBh0XSgkddzxABeX-e=u+iZmE6jq1T0wiy3iOw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Load/Save file in query tool  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Load/Save file in query tool  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view

Hi Surinder

On 13-May-2016 7:12 pm, "Surinder Kumar" <surinder.kumar@enterprisedb.com> wrote:
>
> Hi,
>
> Please find updated patch
>
> Following are the review comments given by Akshay:
> 1. Save button shouldn't enable when data grid is loaded.
> 2. CodeMirror text area change event should only be enabled when query tool is loaded.

I have tested the patch it is not working with Chrome Browser version 48.0 gives error "unexpected token =". I have check error comes in file_manager.js line number 177. It is working fine with Firefox. Please check and send the patch again.

>
>
> On Thu, May 12, 2016 at 1:23 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find attached patch for load/save file in query tool.
>> This patch is dependent on FileManager patch.
>>
>> Do review the patch and let me know for any comments.
>>
>> Thanks,
>> Surinder Kumar
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

pgadmin-hackers by date:

Previous
From: Harshal Dhumal
Date:
Subject: Re: [PATCH] Tables node (pgAdmin4)
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Load, and save the files in the Query Editor.