Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM6581] [React] Port Language node to react - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM6581] [React] Port Language node to react
Date
Msg-id CANxoLDdz5nh8YbaE2qKJpdCueu3Lz13qgUtqhWHuRgLWnQ4WaA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM6581] [React] Port Language node to react  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Responses Re: [pgAdmin][RM6581] [React] Port Language node to react
List pgadmin-hackers
Tree view
Hi Pradip

Following are the review comments:
  • The language name is not visible for the existing language in the properties panel as well as dialog.
  • The "Trusted?" switch is showing the wrong value for the 'plpgsql' language in the properties panel as well as dialog.
  • Unable to provide custom language names as we did before this patch.
  • All the controls on the "Definition" tab are always disabled, also values are not getting populated for existing language.
  • Improve the code coverage to 80%, currently, it is 72.13%

On Thu, Jul 8, 2021 at 7:22 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6581: [React] Port Language node to react

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Pradip Parkale
Date:
Subject: [pgAdmin][RM6581] [React] Port Language node to react
Next
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch] - RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources