Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] : Remove duplicates string literals. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][SonarQube] : Remove duplicates string literals.
Date
Msg-id CANxoLDduNdt4Uyz-mxUHMLhVd9jKzmKvUNmWg4m0nzjwQq4j8w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][SonarQube] : Remove duplicates string literals.  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Responses Re: [pgAdmin][SonarQube] : Remove duplicates string literals.
List pgadmin-hackers
Tree view
Hi Pradip

Following are the review comments:
  • ROLE_NOT_FOUND already in wrapped in gettext() then no need to use like gone(_(ROLE_NOT_FOUND)). In fact, can we use 
    self.not_found_error_msg()instead of new constant.
  • Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext, also we can use this constant for string "
    Error retrieving roles from the database server"

On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Attached is a patch for removing duplicates string literals.
        /server_groups/servers/roles/__init__.py  - 8 places



--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli