Re: Change server password [pgadmin4] - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Change server password [pgadmin4]
Date
Msg-id CANxoLDdq2eW5e+ankFAT4gkCv0P+5v7V9yVmDs74zcu+rOmWzw@mail.gmail.com
Whole thread Raw
In response to Re: Change server password [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: Change server password [pgadmin4]  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Re: Change server password [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Hi Harshal

Below are my review comments :
  • Facing error unexpected identifier 'change_password: function(args)' in js file.
  • Please correct the spelling of password in the menu item.
  • Title for alertify dialog showing "Change password for servers" it should be only "Change Password" or "Change Password for <server name>".
  • Facing error "name 'decrypt' is not defined."
  • Not able to change the password facing error.

On Thu, May 12, 2016 at 1:43 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch.

-- 
Harshal Dhumal
Software Engineer 




On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi, 
This patch needs a rebase. (as "Named restore point" patch is committed.)

-- 
Harshal Dhumal
Software Engineer 




On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for changing server password.


-- 
Harshal Dhumal
Software Engineer 







--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Destroy the existing Select2 object before rerenderin
Next
From: Ashesh Vashi
Date:
Subject: Re: Change server password [pgadmin4]