Re: [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes
Date
Msg-id CANxoLDdd3vZS9D6wsGy5PEWUdurtFoCVXjPzv8kFV9def5eYiA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi Khushboo

Below are the review comments:
  • Can you please add the help message for 'Default' in note control as we do have for 'From/To' control. Also strings are not properly aligned in the note control for Partition Keys and Partitions.
  • Update the documentation and screenshot with the new changes.  
  • Found one issue, Steps to reproduce:
    • Create a partition table with range partition and one child partition of type 'Default'.
    • Open the properties dialog of the newly created partition table and add new child partition with 'Default' = No. Insert all the required field 'Name', 'From' and 'To', still save button is disabled. I am not able to create a new child partition.     
  • If possible can you please fix the RM #3327 which seems to be a small fix, with the same patch.

On Wed, Apr 3, 2019 at 3:42 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix:

1.  # 4104 - Edit data tables with primary key spanning multiple columns [Partition table]
Issue: The partition table having multiple primary keys are not editable from the View data.
2.  # 3938 - Properties of table with default partition not displayed
Issue: The DEFAULT partition is not supported introduced in PG 11. 

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes